Skip to content

Commit

Permalink
types: vtkObject type definition (#182)
Browse files Browse the repository at this point in the history
* Update type definition for vtkObject

* update api docs

* dont cache netlify build
  • Loading branch information
jmannau authored Aug 23, 2022
1 parent 9ebb984 commit 7101279
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion common/reviews/api/core.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import type vtkActor from '@kitware/vtk.js/Rendering/Core/Actor';
import type { vtkCamera } from '@kitware/vtk.js/Rendering/Core/Camera';
import type { vtkImageData } from '@kitware/vtk.js/Common/DataModel/ImageData';
import vtkImageSlice from '@kitware/vtk.js/Rendering/Core/ImageSlice';
import type { VtkObject } from '@kitware/vtk.js/interfaces';
import type { vtkObject } from '@kitware/vtk.js/interfaces';
import vtkPlane from '@kitware/vtk.js/Common/DataModel/Plane';
import type vtkVolume from '@kitware/vtk.js/Rendering/Core/Volume';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { mat4 } from 'gl-matrix';
import type { VtkObject } from '@kitware/vtk.js/interfaces';
import type { vtkObject } from '@kitware/vtk.js/interfaces';

// Copied from VTKCamera

Expand Down Expand Up @@ -29,7 +29,7 @@ interface ICameraInitialValues {
physicalViewNorth?: number[];
}

export interface vtkSlabCamera extends VtkObject {
export interface vtkSlabCamera extends vtkObject {
/**
* Apply a transform to the camera.
* The camera position, focal-point, and view-up are re-calculated
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
publish = "build"

# Rebuild if anything changes, don't scope to this folder
ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../../"
# ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../../"

# COMMENT: NODE_VERSION in root `.nvmrc` takes priority
# COMMENT: Why we specify YARN_FLAGS: https://www.netlify.com/docs/build-gotchas/#yarn
Expand Down

0 comments on commit 7101279

Please sign in to comment.