feat(createImageIdsAndCacheMetaData): Add Sort Instance Number#1305
Open
jlopes90 wants to merge 1 commit intocornerstonejs:mainfrom
Open
feat(createImageIdsAndCacheMetaData): Add Sort Instance Number#1305jlopes90 wants to merge 1 commit intocornerstonejs:mainfrom
jlopes90 wants to merge 1 commit intocornerstonejs:mainfrom
Conversation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kom482
reviewed
Jun 5, 2024
Comment on lines
+56
to
+58
| const sortedInstances = Object.values(instances).sort( | ||
| (a, b) => a[INSTANCE_NUMBER].Value[0] - b[INSTANCE_NUMBER].Value[0] | ||
| ); |
Contributor
There was a problem hiding this comment.
I think you will be interested in checking out this helper: utilities.sortImageIdsAndGetSpacing
Contributor
Author
There was a problem hiding this comment.
I already tested it and it's not right.
async function fetchDicom() {
// Get Cornerstone imageIds for the source data and fetch metadata into RAM
imageIds = await createImageIdsAndCacheMetaData(dev.getConfig.fetchDicom);
//
const { sortedImageIds } = csUtilities.sortImageIdsAndGetSpacing(imageIds);
//
await loadDicom(sortedImageIds.reverse());
}
kom482
approved these changes
Jun 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fix: #1170 (comment)
Changes & Results
Testing
Example Segmentation Volume
https://deploy-preview-1305--cornerstone-3d-docs.netlify.app/live-examples/segmentationVolume.html
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment