Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cornerstone3D 2.0 #1400

Merged
merged 97 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
3c1e4d8
update
sedghi Jul 22, 2024
71d1322
update
sedghi Jul 22, 2024
ebda078
api
sedghi Jul 22, 2024
45f1c6a
chore(version): version.json [skip ci]
Jul 22, 2024
7e6c170
revert createAndCache
sedghi Jul 22, 2024
2349c91
Merge branch 'beta' of github.com:cornerstonejs/cornerstone3D into beta
sedghi Jul 22, 2024
9e66760
chore: Update segmentation rendering trigger functions
sedghi Jul 22, 2024
311c9c3
reorganize
sedghi Jul 22, 2024
c1af6f0
Refactor segmentationId to segmentation in labelmap and segmentation …
sedghi Jul 23, 2024
5950924
update
sedghi Jul 23, 2024
49d47c5
make migration less painful
sedghi Jul 23, 2024
79deb1c
make migration less painful
sedghi Jul 23, 2024
0917735
update
sedghi Jul 23, 2024
c5f3697
update
sedghi Jul 23, 2024
b749b11
update
sedghi Jul 23, 2024
550516e
update docs
sedghi Jul 23, 2024
804dc6a
updates
sedghi Jul 23, 2024
74507cf
performance(volume-rendering): Optimize image-based volume creation a…
sedghi Aug 13, 2024
9e1fb8d
fix: wheel register API change to use binding (#1422)
wayfarer3130 Aug 14, 2024
dd02a05
fix/eslint any types (#1423)
sedghi Aug 15, 2024
f6b9075
fix/beta tests (#1426)
sedghi Aug 21, 2024
6dc7ffc
chore(version): version.json [skip ci]
Aug 21, 2024
de2d08d
chore(version): Update package versions [skip ci]
Aug 21, 2024
002a9f2
remove all circular dependencies (#1433)
sedghi Aug 22, 2024
7bf9904
chore(version): version.json [skip ci]
Aug 22, 2024
2728527
chore(version): Update package versions [skip ci]
Aug 22, 2024
e1eefd7
more beta stuff (#1434)
sedghi Aug 22, 2024
fcf5d14
chore(version): version.json [skip ci]
Aug 22, 2024
59acc61
chore(version): Update package versions [skip ci]
Aug 22, 2024
ca4a3d0
remove getScalars (#1435)
sedghi Aug 22, 2024
e07a8e2
chore(version): version.json [skip ci]
Aug 22, 2024
35b061e
chore(version): Update package versions [skip ci]
Aug 22, 2024
935bfd7
remove implemnets (#1437)
sedghi Aug 23, 2024
69cb27c
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into beta
sedghi Aug 23, 2024
cd21bea
chore(version): version.json [skip ci]
Aug 23, 2024
9094790
chore(version): Update package versions [skip ci]
Aug 23, 2024
01ee415
update
sedghi Aug 23, 2024
81d9c98
Merge branch 'beta' of github.com:cornerstonejs/cornerstone3D into beta
sedghi Aug 23, 2024
25b4490
chore(version): version.json [skip ci]
Aug 23, 2024
0057ad1
chore(version): Update package versions [skip ci]
Aug 23, 2024
7f893a3
try to run tests for beta
sedghi Aug 25, 2024
1b33e03
Merge branch 'beta' of github.com:cornerstonejs/cornerstone3D into beta
sedghi Aug 25, 2024
2001486
fix/releases (#1441)
sedghi Aug 26, 2024
8f91e70
chore(version): version.json [skip ci]
Aug 26, 2024
db51843
chore(version): Update package versions [skip ci]
Aug 26, 2024
58d3753
try to not publish source maps (#1442)
sedghi Aug 26, 2024
b253cf4
Fix htj2k decoder
wayfarer3130 Aug 29, 2024
51f7cde
feat(segmentation): Refactor segmentation and style handling (#1449)
sedghi Sep 12, 2024
c7af78b
chore(version): version.json [skip ci]
Sep 12, 2024
f07f340
chore(version): Update package versions [skip ci]
Sep 12, 2024
580dc4b
fix: segmentation and versioned docs(#1488)
sedghi Oct 1, 2024
c5ba018
fix: Dynamic threshold wasn't working in the beta branch (#1470)
wayfarer3130 Oct 1, 2024
ac3e721
chore(version): version.json [skip ci]
Oct 1, 2024
fd9316c
chore(version): Update package versions [skip ci]
Oct 1, 2024
5db0565
wip for migration guides
sedghi Oct 2, 2024
fd6c3b2
wip
sedghi Oct 3, 2024
4f36be1
wip
sedghi Oct 3, 2024
fff67db
wip
sedghi Oct 4, 2024
d6845f7
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into beta
sedghi Oct 4, 2024
6db394e
wip
sedghi Oct 4, 2024
4a9c87d
change request type to enum capital
sedghi Oct 4, 2024
7e2f3b5
add back volume rotate mouse wheel
sedghi Oct 4, 2024
e37ba6c
wip
sedghi Oct 4, 2024
e5287e7
wip
sedghi Oct 4, 2024
d5c4b15
Merge branch 'beta' of github.com:cornerstonejs/cornerstone3D into beta
sedghi Oct 4, 2024
3592551
wip
sedghi Oct 4, 2024
0b91583
chore(version): version.json [skip ci]
Oct 4, 2024
e56a9df
chore(version): Update package versions [skip ci]
Oct 4, 2024
f670229
feat(image loaders): Allow reusing DICOM image loader code for custom…
sgielen Oct 25, 2024
ca4475f
docs(image loader/metadata provider): Clarify concept + how-to docume…
sgielen Oct 25, 2024
f8867a6
final/stuff beta (#1495)
sedghi Oct 25, 2024
5d0deec
stuff
sedghi Oct 25, 2024
dea5efd
fix all tests
sedghi Oct 25, 2024
53ddb02
fix playwright
sedghi Oct 25, 2024
034ca01
fix tests
sedghi Oct 25, 2024
4b5a8b3
fix tests
sedghi Oct 25, 2024
d7855d5
fix netlify
sedghi Oct 25, 2024
f83a1a7
fix build
sedghi Oct 25, 2024
a8d7171
fix build
sedghi Oct 25, 2024
2bcd9eb
update docs
sedghi Oct 25, 2024
5addf8e
fix ios
sedghi Oct 25, 2024
57c1bc5
progress
sedghi Oct 28, 2024
ca63091
progress
sedghi Oct 28, 2024
05b1d28
works
sedghi Oct 28, 2024
d0af5ac
delete dicom loader api
sedghi Oct 28, 2024
11a111f
fix docs
sedghi Oct 28, 2024
e9fe133
fix playwrights
sedghi Oct 28, 2024
b008dd5
fix
sedghi Oct 28, 2024
2ca25f8
fix
sedghi Oct 28, 2024
a74584b
fix
sedghi Oct 28, 2024
e0a55b3
wip
sedghi Oct 28, 2024
c060556
wip
sedghi Oct 28, 2024
bbb47d2
wip
sedghi Oct 28, 2024
e3a0cce
wip
sedghi Oct 28, 2024
41a9e6a
vesion
sedghi Oct 28, 2024
ab6d76a
wip
sedghi Oct 29, 2024
759f162
update api
sedghi Oct 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
19 changes: 15 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ jobs:
paths:
- packages/core/dist
- packages/tools/dist
- packages/streaming-image-volume-loader/dist
- packages/adapters/dist
- packages/dicomImageLoader/dist
- packages/nifti-volume-loader/dist
Expand All @@ -60,6 +59,12 @@ jobs:
- attach_workspace:
at: ~/repo
- run: yarn run api-check
FORMAT_CHECK:
<<: *defaults
steps:
- attach_workspace:
at: ~/repo
- run: yarn run format-check

# https://circleci.com/docs/2.0/collect-test-data/#karma
TEST:
Expand Down Expand Up @@ -129,6 +134,9 @@ workflows:
- BUILD:
requires:
- CHECKOUT
- FORMAT_CHECK:
requires:
- BUILD
- API_CHECK:
requires:
- BUILD
Expand All @@ -144,16 +152,19 @@ workflows:
branches:
only:
- main
- beta
# - beta
- BUILD:
requires:
- CHECKOUT
- HOLD_FOR_APPROVAL:
type: approval
requires:
- BUILD
- TEST:
requires:
- CHECKOUT
- NPM_PUBLISH:
requires:
- BUILD
- TEST
- HOLD_FOR_APPROVAL

# VS Code Extension Version: 1.5.1
86 changes: 55 additions & 31 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@
// - @typescript-eslint
//
//
// eslint-plugin-import
// - import
"plugins": [
"@typescript-eslint/eslint-plugin",
"@typescript-eslint",
"import",
"eslint-plugin-tsdoc",
"prettier"
Expand All @@ -41,42 +40,44 @@
// -
"extends": [
"eslint:recommended",
"plugin:import/errors",
"plugin:import/warnings",
"plugin:import/typescript",
"plugin:@typescript-eslint/recommended",
// sets up the plugin AND eslint-config-prettier
"plugin:prettier/recommended"
],

"parserOptions": {
"ecmaVersion": 2021,
"ecmaVersion": 2022,
"sourceType": "module",
"project": "./tsconfig.json",
"tsconfigRootDir": "./"
"tsconfigRootDir": "./",
"warnOnUnsupportedTypeScriptVersion": false
},
"ignorePatterns": ["packages/docs"],
"ignorePatterns": ["packages/docs", "dist", "**/*_test.js", "**/*_jest.js", "**/*babel*", "**/*.d.ts", "**/*_types.ts"],
"rules": {
"import/no-cycle": ["error", { "maxDepth": 15 }],
// Enforce consistent brace style for all control statements for readability
"curly": "error",
"tsdoc/syntax": "warn",
"tsdoc/syntax": "off",
"@typescript-eslint/ban-ts-comment": "off",
"import/no-cycle": "error",
"no-console": [
"warn",
{
"allow": ["warn", "error"]
}
],
// note you must disable the base rule
// as it can report incorrect errors
"no-console": "off",
"no-unused-vars": "off",
// Allow skipping unused variables in params calls by using _Name
"@typescript-eslint/no-unused-vars": [
"warn", // or "error"
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/consistent-type-exports": "error",
"@typescript-eslint/no-unsafe-function-type": "off",
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/no-unused-expressions": "warn",
"@typescript-eslint/consistent-type-imports": [
"error",
{
"argsIgnorePattern": "^_",
"varsIgnorePattern": "^_",
"caughtErrorsIgnorePattern": "^_"
"prefer": "type-imports",
"disallowTypeAnnotations": true
}
],
"@typescript-eslint/no-import-type-side-effects": "error",

"import/extensions": [
"error",
"ignorePackages",
Expand All @@ -88,37 +89,60 @@
}
],
"import/prefer-default-export": "off",
// eslint-plugin-prettier
"prettier/prettier": [
"error",
{
"endOfLine": "auto",
"printWidth": 80
}
],
"no-undef": "warn"
"no-undef": "warn",
"import/no-named-as-default": "off",
"import/no-named-as-default-member": "off"
},

"overrides": [
{
"files": ["*.ts", "*.tsx"], // Apply the rules to TypeScript files
"rules": {
"import/no-cycle": ["error", { "maxDepth": 15 }]
}
},
{
"files": ["**/examples/**"],
"rules": {
"@typescript-eslint/no-explicit-any": "off" // Disable the rule for files in the examples directory
}
}
],
"env": {
"es6": true,
"browser": true,
"node": true
},

"settings": {
"react": {
"version": "detect"
},
"import/resolver": {
"node": {
"extensions": [".js", ".jsx", ".ts", ".tsx"]
},
"typescript": {
"project": "./tsconfig.json"
}
}
},

"globals": {
"context": true,
"assert": true,
"SharedArrayBuffer": true
"jasmine": true,
"es6": true,
"browser": true,
"node": true,
"afterEach": true,
"beforeEach": true,
"done": true,
"describe": "readonly",
"beforeAll": "readonly",
"it": "readonly",
"jest": "readonly",
"expect": "readonly",
"assert": true
}
}
9 changes: 5 additions & 4 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
playwright-tests:
timeout-minutes: 60
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
Expand All @@ -18,12 +18,14 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: 18
- name: Install dependencies playwright
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Install Playwright Browsers
run: npx playwright install --with-deps
- name: Run Playwright tests
run: export NODE_OPTIONS="--max_old_space_size=8192" && npx playwright test --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
run:
export NODE_OPTIONS="--max_old_space_size=8192" && npx playwright test --shard=${{
matrix.shardIndex }}/${{ matrix.shardTotal }}

- name: Upload blob report to GitHub Actions Artifacts
if: ${{ !cancelled() }}
Expand All @@ -36,7 +38,6 @@ jobs:
merge-reports:
if: ${{ !cancelled() }}
needs: [playwright-tests]

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ package-lock.json

# Example output
.static-examples
.static-examples-playwright

# Docs output
packages/docs/dist/
Expand Down
3 changes: 1 addition & 2 deletions .husky/pre-commit
100755 → 100644
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"
# .husky/pre-commit

yarn lint-staged
4 changes: 0 additions & 4 deletions .webpack/webpack.base.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ module.exports = (env, argv, { DIST_DIR }) => {
resolve: {
modules: [path.resolve(PROJECT_ROOT, './node_modules'), SRC_PATH],
extensions: ['.ts', '.tsx', '.js', '.jsx'],
alias: {
'@cornerstonejs/dicom-image-loader':
'@cornerstonejs/dicom-image-loader/dist/dynamic-import/cornerstoneDICOMImageLoader.min.js',
},
fallback: {
fs: false,
path: require.resolve('path-browserify'),
Expand Down
Loading
Loading