Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rendering): norm16 and half float was not scaling correctly #1404

Merged
merged 3 commits into from
Jul 27, 2024
Merged

fix(rendering): norm16 and half float was not scaling correctly #1404

merged 3 commits into from
Jul 27, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jul 26, 2024 •
edited
Loading

fixes #1397
fixes OHIF/Viewers#4289

@netlify Netlify
Copy link

netlify bot commented Jul 26, 2024 •
edited
Loading

✅ Deploy Preview for cornerstone-3d-docs canceled.

Name Link
🔨 Latest commit 87eb403
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/66a443ac2a69c00008884a0b

@sedghi sedghi changed the title fix/int16 hu fix/int16 scaling issues Jul 26, 2024
@sedghi sedghi changed the title fix/int16 scaling issues fix(rendering): norm16 and half float was not scaling correctly Jul 26, 2024
@sedghi sedghi merged commit fd218e8 into main Jul 27, 2024
15 checks passed
@Enriquez-Johnmark
Copy link

Enriquez-Johnmark commented Jul 29, 2024 •
edited
Loading

Hi @sedghi
Could you kindly guide me on how to properly apply the updated Cornerstone changes to OHIF version 3.8.3? I mean the norm16 fix
Thank you

@Enriquez-Johnmark
Copy link

If I use sudo rm yarn.lock and then run yarn install and yarn run build, I encounter performance issues. Specifically, there are problems with large scans. This contrasts with the 3.8.3 build and the 1.77.6 CS3D version, where the performance is good.

@sedghi sedghi mentioned this pull request Aug 23, 2024
Merged
@David2k13
Copy link
Contributor

#1728
@
I read the submitted code. But my abilities are limited,
I hope I can get help, thank you

@sedghi sedghi deleted the fix/int16-hu branch January 22, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sedghi @Enriquez-Johnmark @David2k13