-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SR): SCOORD3D point annotations support for volume and stack viewports #1446
Closed
igoroctaviano
wants to merge
8
commits into
cornerstonejs:main
from
igoroctaviano:feat/scoord3d-point-annotations-support-updated
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e9b82e2
Add vol and stack scoord3d point support
igoroctaviano 7e04bfd
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fe…
igoroctaviano e72c99e
Mterge branch 'main' of github.com:cornerstonejs/cornerstone3D into f…
igoroctaviano b0e500b
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fe…
igoroctaviano fb6134c
CR Updates
igoroctaviano b53eaaf
Update api
igoroctaviano 172e594
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fe…
igoroctaviano 5b98955
Refactor func
igoroctaviano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,4 @@ | |
} | ||
}] | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
packages/core/src/RenderingEngine/helpers/findIndexByFOR.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import * as metaData from '../../metaData'; | ||
|
||
const findIndexByFOR = ({ | ||
imageIds, | ||
FrameOfReferenceUID, | ||
cameraFocalPoint, | ||
}) => { | ||
let foundIndex = -1; | ||
for (let i = 0; i < imageIds.length; ++i) { | ||
const imageMetadata = metaData.get('instance', imageIds[i]); | ||
if (imageMetadata.FrameOfReferenceUID !== FrameOfReferenceUID) { | ||
continue; | ||
} | ||
|
||
const sliceNormal = [0, 0, 0]; | ||
const orientation = imageMetadata.ImageOrientationPatient; | ||
sliceNormal[0] = | ||
orientation[1] * orientation[5] - orientation[2] * orientation[4]; | ||
sliceNormal[1] = | ||
orientation[2] * orientation[3] - orientation[0] * orientation[5]; | ||
sliceNormal[2] = | ||
orientation[0] * orientation[4] - orientation[1] * orientation[3]; | ||
|
||
let distanceAlongNormal = 0; | ||
for (let j = 0; j < 3; ++j) { | ||
distanceAlongNormal += | ||
sliceNormal[j] * imageMetadata.ImagePositionPatient[j]; | ||
} | ||
|
||
/** Assuming 2 mm tolerance */ | ||
if (Math.abs(distanceAlongNormal - cameraFocalPoint[2]) > 2) { | ||
continue; | ||
} | ||
foundIndex = i; | ||
break; | ||
} | ||
return foundIndex; | ||
}; | ||
|
||
export default findIndexByFOR; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,6 +69,8 @@ export type ReferenceCompatibleOptions = { | |
* not need to be provided. | ||
*/ | ||
imageURI?: string; | ||
isFiltering?: boolean; | ||
currentImageId?: string; | ||
Comment on lines
+72
to
+73
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think these belongs here |
||
}; | ||
|
||
/** | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no scenario where we don't have cameraFocalPoint