Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Color conversion is required for RGB and planar configuration 1 #1457

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

wayfarer3130
Copy link
Collaborator

@wayfarer3130 wayfarer3130 commented Sep 5, 2024

Context

Color conversion was inadvertently turned off for color by plane. This PR just turns it back on again.

Changes & Results

Added an or condition with planar configuration 1 for the isColorConversionRequired method. This turns on conversion for color by plane.

Testing

See linked issues for test dicom to test this with.
#4359 and #4231

Linked into OHIF for testing. This displays the right image.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 76f302b
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/66da03f125106600086bdba2
😎 Deploy Preview https://deploy-preview-1457--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi merged commit 3bafe59 into main Sep 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants