feat: added MIP option to StackScrollTool #537
Conversation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ouwen
force-pushed
the
gradienthealth/added_mip_option
branch
from
4f7356a to
6b72360
Compare
Ouwen
force-pushed
the
gradienthealth/added_mip_option
branch
from
6b72360 to
76a2109
Compare
|
@sedghi, this PR is ready for your review! |
| constructor( | ||
| toolProps: PublicToolProps = {}, | ||
| defaultToolProps: ToolProps = { | ||
| supportedInteractionTypes: ['Mouse', 'Touch'], | ||
| configuration: { | ||
| invert: false, | ||
| leftRightMode: false, |
There was a problem hiding this comment.
what is the difference between leftRightMode and mipMode? can leftRightMode be not mipMode? to me this configuration is complex and not clear at the first glance. there are multiple levels that has enabled, how about something like
configuration: {
activeMode: 'stackScrollMode', // or 'mipMode'
stackScrollMode: {
invert: false,
loop: false,
debounceIfNotLoaded: true,
},
mipMode: {
pixelsPerThickness: 5,
minSlabThickness: 5e-2,
maxSlabThickness: 30,
},
},
There was a problem hiding this comment.
So the following options need some way to be selected...
leftRight vs upDown
Inversion is rightLeft vs downUp
Then MIP can be active/inactive
StackScroll can be active/inactive
Both MIP and StackScroll can be active at the same time.
What about something like this:
configuration: {
direction: {
stackScrollMode: enums['upDown', 'downUp', null]
mipMode: enums['leftRight', 'rightLeft', null]
},
stackScrollMode: {
loop: false,
debounceIfNotLoaded: true,
},
mipMode: {
pixelsPerThickness: 5,
minSlabThickness: 5e-2,
maxSlabThickness: 30,
},
},There was a problem hiding this comment.
how about we stick to horizontal and vertical and assume (naturally) that right is more and up is more, and we have a invert flag?
configuration: {
stackScrollMode: {
enabled: true,
invert: true,
direction: 'vertical'
loop: false,
debounceIfNotLoaded: true,
},
mipMode: {
enabled: false,
invert: true,
direction: 'horizontal'
pixelsPerThickness: 5,
minSlabThickness: 5e-2,
maxSlabThickness: 30,
},
},
| leftRightMode: false, | ||
| mipMode: { | ||
| enabled: true, | ||
| invert: false, | ||
| pixelsPerThickness: 5, | ||
| minSlabThickness: 5e-2, | ||
| maxSlabThickness: 30, | ||
| }, |
There was a problem hiding this comment.
I guess this example should get updated too right?
There was a problem hiding this comment.
yep still need to push the changes
No description provided.