Minor improvements to test updating programs #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhicks1
reviewed
Dec 11, 2020
mwhicks1
approved these changes
Dec 11, 2020
mattmccutchen-cci
force-pushed
the
test-updating-programs-minor
branch
from
d8120ee
to
dd7df6c
Compare
- Make directly executable (on Linux at least). - Chdir to the containing directory if needed. - Search for `3c` via $LLVM_OBJ, the standard build directory location, and $PATH (in that order) rather than requiring the user to modify an absolute path hard-coded in the program.
This is consistent with our prior cleanup in 8878fe5.
mattmccutchen-cci
force-pushed
the
test-updating-programs-minor
branch
from
dd7df6c
to
2e1bde3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to facilitate my work on factoring the
RUNcommands out of the test files for #346.