Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug level into alpine build #121

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

rgithubli
Copy link
Contributor

Description

Currently the alpine image name does not contain debug level. It does not match debug build folder name format and leads to incomplete JDK in debug builds (JDK does not have any content except for first level files such as README, LICENSE etc). This change fixes the issue.

Related issues

This is a part of fix for corretto/corretto-22#9. In addition to this fix, we have to fix internal build scripts as well.

Need to backport this change to other versions.

How has this been tested?

Tested with internal build pipeline and can see right binaries being generated now:

/tmp/alpine/fix/amazon-corretto-24.0.0.10.1-alpine-linux-x64 # ./bin/java -version
openjdk version "24" 2025-03-18
OpenJDK Runtime Environment Corretto-24.0.0.10.1 (fastdebug build 24+10-FR)
OpenJDK 64-Bit Server VM Corretto-24.0.0.10.1 (fastdebug build 24+10-FR, mixed mode, sharing)

Platform information

/tmp/alpine/fix/amazon-corretto-24.0.0.10.1-alpine-linux-x64 # cat /etc/os-release 
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.16.9
PRETTY_NAME="Alpine Linux v3.16"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"

@rgithubli rgithubli requested a review from chadrako August 14, 2024 20:30
@rgithubli rgithubli changed the title Fix alpine image name with proper debug level Add debug level into alpine build Aug 14, 2024
@rgithubli rgithubli requested a review from mrserb August 14, 2024 20:30
@rgithubli rgithubli merged commit 20dd340 into corretto:develop Aug 14, 2024
88 checks passed
@rgithubli rgithubli deleted the alpine-debug branch August 14, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants