-
Notifications
You must be signed in to change notification settings - Fork 16
Feat/status board #198
base: develop
Are you sure you want to change the base?
Feat/status board #198
Conversation
…nto developOOO * 'developesc' of https://github.com/cardene/ember-share: render id and status rendering id and status Rendering id and status Template edits
…nto developOOO * 'developesc' of https://github.com/cardene/ember-share: emoji icon statuses
…nto developOOO * 'developesc' of https://github.com/cardene/ember-share: model of history page format-- incorrect data data rendering on new url new url harvest-history but no data rendering yet # Conflicts: # app/templates/harvest-history.hbs
…nto developOOO * 'developesc' of https://github.com/cardene/ember-share: # Conflicts: # app/templates/harvest-history.hbs
…nto developOOO
…into developOOO # Conflicts: # app/templates/status-board.hbs
…into developOOO # Conflicts: # app/controllers/status-board.js
…into Feat/Nav-fix # Conflicts: # app/components/page-nav.js # app/controllers/status-board.js # app/templates/components/page-nav.hbs # app/templates/status-board.hbs
…nto Feat/Status-Board # Conflicts: # app/components/page-nav.js # app/templates/status-board.hbs
| @@ -0,0 +1,4 @@ | |||
| import Ember from 'ember'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also fix jslint errors; delete excess files and unneeded tests; do the breadcrumb thing; move components to pod structure
good job!
.eslintrc.js
Outdated
| @@ -0,0 +1,13 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file
app/adapters/harvest-log.js
Outdated
|
|
||
| export default ApplicationAdapter.extend({ | ||
| pathForType() { | ||
| return 'HarvestLog'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to match api (and remove this adapter probably)
| }, | ||
| ajax(url, type, options) { | ||
| if (options) { | ||
| options.traditional = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove, probably
app/adapters/source-config.js
Outdated
|
|
||
| export default ApplicationAdapter.extend({ | ||
| pathForType() { | ||
| return 'SourceConfig'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this adapter (probably)
| @@ -0,0 +1,7 @@ | |||
| import ApplicationAdapter from './application'; | |||
|
|
|||
| export default ApplicationAdapter.extend({ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this adapter probably
| </h1> | ||
|
|
||
| <h2 style="font-size:2rem; padding: 8px; width: 95%; margin-left: 20px; line-height: 130%; background-color: #F8F8F8" > | ||
| {{model.context}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preserve formatting (newlines, indentation)
| {{#status-context status=model.status}}{{/status-context}} | ||
| </h1> | ||
|
|
||
| <h2 style="font-size:2rem; padding: 8px; width: 95%; margin-left: 20px; line-height: 130%; background-color: #F8F8F8" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
styles
bower.json
Outdated
| "name": "ember-share", | ||
| "dependencies": { | ||
| "ember": "~2.5.0", | ||
| "ember": "2.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.5.x
config/targets.js
Outdated
| @@ -0,0 +1,9 @@ | |||
| /* eslint-env node */ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
tests/.eslintrc.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete

Purpose
Changes
Side effects
Ticket