Skip to content

Commit

Permalink
Env: Default RES knob to 0.25. Better tooltip for center frequency.
Browse files Browse the repository at this point in the history
  • Loading branch information
cosinekitty committed Feb 11, 2025
1 parent 0339dd8 commit ecf9d68
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/env_pitch_detect.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ namespace Sapphire
info.resize(maxChannels);
setThreshold();
setSpeed();
setFrequency();
setResonance();
initialize();
}

Expand Down Expand Up @@ -213,7 +215,7 @@ namespace Sapphire
q.pitchFilter.setFrequency(knob);
}

void setResonance(value_t knob = 0)
void setResonance(value_t knob = 0.25)
{
for (info_t& q : info)
q.pitchFilter.setResonance(knob);
Expand Down
4 changes: 2 additions & 2 deletions src/env_vcv.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ namespace Sapphire
config(PARAMS_LEN, INPUTS_LEN, OUTPUTS_LEN, LIGHTS_LEN);
configControlGroup("Threshold", THRESHOLD_PARAM, THRESHOLD_ATTEN, THRESHOLD_CV_INPUT, -96, 0, -24, " dB");
configControlGroup("Speed", SPEED_PARAM, SPEED_ATTEN, SPEED_CV_INPUT, 0, 1, 0.5);
configControlGroup("Frequency", FREQ_PARAM, FREQ_ATTEN, FREQ_CV_INPUT, -Gravy::OctaveRange, +Gravy::OctaveRange, Gravy::DefaultFrequencyKnob);
configControlGroup("Resonance", RES_PARAM, RES_ATTEN, RES_CV_INPUT, 0, 1, Gravy::DefaultResonanceKnob);
configControlGroup("Center frequency", FREQ_PARAM, FREQ_ATTEN, FREQ_CV_INPUT, -Gravy::OctaveRange, +Gravy::OctaveRange, Gravy::DefaultFrequencyKnob);
configControlGroup("Resonance", RES_PARAM, RES_ATTEN, RES_CV_INPUT, 0, 1, 0.25);
configInput(AUDIO_INPUT, "Audio");
configOutput(ENVELOPE_OUTPUT, "Envelope");
configOutput(PITCH_OUTPUT, "Pitch V/OCT");
Expand Down

0 comments on commit ecf9d68

Please sign in to comment.