Skip to content

admin character panel #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

lunarcomets
Copy link
Contributor

@lunarcomets lunarcomets commented Nov 18, 2024

About the PR

adds a character panel for admins to use to look up a player's current character's description, records, and event preferences to help with game master events. confidential records can come in another pr

Why / Balance

because currently looking at a player's preferences is pretty difficult due to the requirement of toolshed, this also consolidates most of a current character's information into one panel for an admin to get a quick overview of.

Technical details

to-do: this

Media

to-do: also this

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

for admins: adds the character panel to more easily see details about a player's current character

@dffdff2423 dffdff2423 linked an issue Nov 19, 2024 that may be closed by this pull request
@lunarcomets lunarcomets changed the title Character panel and (hopefully) confidential records admin character panel Nov 19, 2024
@lunarcomets
Copy link
Contributor Author

@dffdff2423 regarding the link of the issue: as i'm working on this, it's currently going towards the panel only displaying the player's current in-round character, not being able to select from all of a player's profiles as is ideal in the issue. is that something that can just be added later, and would the current character data (which should be gotten from the db either way) be good enough for now?

@dffdff2423
Copy link
Collaborator

Yep! That is perfectly fine. I don't expect adding the ability to view other profiles will be that hard to add if you are already fetching them from the DB.

@dffdff2423 dffdff2423 linked an issue Dec 17, 2024 that may be closed by this pull request
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Changes: Sprites Changes to sprites. Changes: Map Changes to map files. Changes: UI Changes to UI files. Changes: Shaders Changes to shanders Changes: Audio labels Mar 11, 2025
Copy link
Contributor

RSI Diff Bot; head commit e83a990 merging into 41c5fbd
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

@lunarcomets
Copy link
Contributor Author

lunarcomets commented Mar 11, 2025

i made a fucky woops
@dffdff2423 Help

@dffdff2423
Copy link
Collaborator

What exactly is the issue? If you are talking about merge conflicts I normally advise rebasing (and force pushing) over merging but it looks like you resolved them.

@lunarcomets
Copy link
Contributor Author

oh yeah they were fixed, it was more an issue of having like a million codes of lines being in this pr but it seems fixed now so :monkofjoy:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes: Map Changes to map files. Changes: Shaders Changes to shanders Changes: Sprites Changes to sprites. Changes: UI Changes to UI files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Character Panel Replace Admin Records Console with a general player info page.
2 participants