votelink (pda voting !!!) #481
Conversation
There was a problem hiding this comment.
Looks mostly fine, mainly just stylistic changes below.
I found a few small issues while testing in-game:
- There is no way for players to see the cooldown. Could you put it in the tooltip?
- I am fairly certain that the "new vote" button stays disabled after the cooldown elapses requiring you to re-open the UI.
- There is no cap on time remaining which means that people are able to disable votes for a round by creating a really long vote.
- Given that it is intended to be a PDA cartridge, it may be better stylistically to not have popups. Instead change the contents of the PDA. However, if this is hard to do it is not a big deal.
| var container = new BoxContainer | ||
| { | ||
| Orientation = BoxContainer.LayoutOrientation.Horizontal, | ||
| Margin = new Thickness(0, 2), | ||
| }; | ||
|
|
||
| var inputPanel = new PanelContainer | ||
| { | ||
| StyleClasses = { "ButtonSquare" }, | ||
| HorizontalExpand = true, | ||
| }; | ||
|
|
||
| var input = new LineEdit | ||
| { | ||
| PlaceHolder = Loc.GetString("vote-link-option-placeholder", ("number", _optionInputs.Count + 1)), | ||
| HorizontalExpand = true, | ||
| }; |
There was a problem hiding this comment.
Was this a deliberate choice to not create another XAML file for this?
| foreach (var vote in history.OrderByDescending(v => v.StartTime)) | ||
| { | ||
| var entry = new PanelContainer | ||
| { | ||
| HorizontalExpand = true, | ||
| StyleClasses = { "AngleRect" }, | ||
| Margin = new Thickness(0, 0, 0, 8), |
There was a problem hiding this comment.
The UI stuff created in this loop probably should be their own XAML file.
| CreateVoteButton.ToolTip = !state.HasAccess | ||
| ? Loc.GetString("vote-link-no-access") | ||
| : _activeVote != null | ||
| ? Loc.GetString("vote-link-create-disabled") | ||
| : onCooldown | ||
| ? Loc.GetString("vote-link-on-cooldown") | ||
| : null; // amazing |
There was a problem hiding this comment.
This nested ternary operator is incredibly cursed but I will not die on this hill
| if (totalVotes > 0) | ||
| { | ||
| // Display options sorted by vote count | ||
| foreach (var option in _lastCompletedVote.Options |
There was a problem hiding this comment.
Again, might be preferable to create another control for this. However, I am not fully convinced on this one because it is almost entirely created programatically.
| return GetPredictedVoteCount(VoteOption.Abstain, vote); | ||
| } | ||
|
|
||
| private void CreateVoteDisplay(VoteData vote) |
There was a problem hiding this comment.
This probably should be XAML.
| public readonly int Votes = votes; | ||
| } | ||
|
|
||
| [DataDefinition] [Serializable] [NetSerializable] |
|
|
||
| namespace Content.Shared._CD.CartridgeLoader.Cartridges; | ||
|
|
||
| [Serializable] [NetSerializable] |
| public readonly VoteData? VoteData = voteData; | ||
| } | ||
|
|
||
| [Serializable] [NetSerializable] |
| RequestHistory, | ||
| } | ||
|
|
||
| [Serializable] [NetSerializable] |
| /// <summary> | ||
| /// Handles the global VoteLink elements. | ||
| /// </summary> | ||
| [RegisterComponent] [Access(typeof(VoteLinkSystem))] [AutoGenerateComponentPause] |
yes I hear that but I personally prefer doing popups for stuff like this mainly for accessibility reasons: PDAs have a locked size, but you can resize popups, open multiple at once |
| public sealed class VoteStartedEvent(EntityUid station) : EntityEventArgs | ||
| { | ||
| public EntityUid Station = station; | ||
| } | ||
|
|
||
| public sealed class VoteEndedEvent(EntityUid station) : EntityEventArgs | ||
| { | ||
| public EntityUid Station = station; | ||
| } | ||
|
|
||
| public sealed class VoteUpdatedEvent(EntityUid station) : EntityEventArgs | ||
| { | ||
| public EntityUid Station = station; | ||
| } |
There was a problem hiding this comment.
why are these classes
| VoteData? activeVote, | ||
| List<VoteData> history, | ||
| TimeSpan? cooldown = null, | ||
| bool hasAccess = false) |
There was a problem hiding this comment.
why just check access on the client
There was a problem hiding this comment.
how the fuck did I miss this :(
There was a problem hiding this comment.
i already forgot how this code works, saw this and went "what why the fuck"
There was a problem hiding this comment.
That is what you get for coding while sleep-deprived. If I remember correctly I also reviewed this at midnight.
| private void OnVoteStarted(VoteStartedEvent ev) | ||
| { | ||
| UpdateAllCartridges(ev.Station); | ||
| } | ||
|
|
||
| private void OnVoteEnded(VoteEndedEvent ev) | ||
| { | ||
| UpdateAllCartridges(ev.Station); | ||
| } | ||
|
|
||
| private void OnVoteUpdated(VoteUpdatedEvent ev) | ||
| { | ||
| UpdateAllCartridges(ev.Station); | ||
| } |
There was a problem hiding this comment.
looks like shit maybe make it better??
About the PR
adds the VoteLink cartridge, a new app that lets you create polls and vote in them!
comes preinstalled on all PDAs
creating polls is restricted to command
5 minute cooldown, voting is predicted, timer updates separately, everything is in the code :godo:
Why / Balance
i thought it'd be cool
with each PR we're closer to PDA messaging
Media
Click me!
hiiiii