Skip to content

Change frequent frame/enumeration logs from info to debug #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FreddyFunk merged 1 commit into from
Feb 3, 2026
Merged

Change frequent frame/enumeration logs from info to debug #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/camera_preview/widget.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use crate::fl;
use cosmic::Element;
use cosmic::iced::{Background, Length};
use cosmic::widget;
use tracing::info;
use tracing::{debug, info};

impl AppModel {
/// Build the camera preview widget
Expand Down Expand Up @@ -44,7 +44,7 @@ impl AppModel {
std::sync::atomic::AtomicU64::new(0);
let count = VIEW_FRAME_COUNT.fetch_add(1, std::sync::atomic::Ordering::Relaxed);
if count.is_multiple_of(30) {
info!(
debug!(
frame = count,
width = frame.width,
height = frame.height,
Expand Down
2 changes: 1 addition & 1 deletion src/app/handlers/camera.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ impl AppModel {
static FRAME_MSG_COUNT: std::sync::atomic::AtomicU64 = std::sync::atomic::AtomicU64::new(0);
let count = FRAME_MSG_COUNT.fetch_add(1, std::sync::atomic::Ordering::Relaxed);
if count.is_multiple_of(30) {
info!(
debug!(
message = count,
width = frame.width,
height = frame.height,
Expand Down
4 changes: 2 additions & 2 deletions src/app/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ impl cosmic::Application for AppModel {
frame.captured_at.elapsed().as_micros();

if frame_count.is_multiple_of(30) {
info!(
debug!(
frame = frame_count,
width = frame.width,
height = frame.height,
Expand All @@ -787,7 +787,7 @@ impl cosmic::Application for AppModel {
{
Ok(_) => {
if frame_count.is_multiple_of(30) {
info!(
debug!(
frame = frame_count,
"Frame forwarded to UI"
);
Expand Down
6 changes: 3 additions & 3 deletions src/backends/camera/pipewire/enumeration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ pub fn enumerate_pipewire_cameras() -> Option<Vec<CameraDevice>> {
return None;
}

info!("✓ PipeWire available for camera enumeration");
debug!("PipeWire available for camera enumeration");

// PipeWire camera enumeration strategy:
// 1. Try to discover cameras through pw-cli/pactl (if available)
Expand All @@ -38,7 +38,7 @@ pub fn enumerate_pipewire_cameras() -> Option<Vec<CameraDevice>> {
let cameras = try_enumerate_with_pw_cli().or_else(try_enumerate_with_pactl);

if let Some(ref cams) = cameras {
info!(count = cams.len(), "Found PipeWire cameras");
debug!(count = cams.len(), "Found PipeWire cameras");
return Some(cams.clone());
}

Expand Down Expand Up @@ -206,7 +206,7 @@ fn try_enumerate_with_pw_cli() -> Option<Vec<CameraDevice>> {
debug!("No cameras found via pw-cli");
None
} else {
info!(count = cameras.len(), "Enumerated cameras via pw-cli");
debug!(count = cameras.len(), "Enumerated cameras via pw-cli");
Some(cameras)
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/backends/camera/pipewire/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,13 @@ impl PipeWireBackend {

impl CameraBackend for PipeWireBackend {
fn enumerate_cameras(&self) -> Vec<CameraDevice> {
info!("Using PipeWire backend for camera enumeration");
debug!("Using PipeWire backend for camera enumeration");

if let Some(cameras) = enumerate_pipewire_cameras() {
info!(count = cameras.len(), "PipeWire cameras enumerated");
debug!(count = cameras.len(), "PipeWire cameras enumerated");
cameras
} else {
info!("PipeWire enumeration returned None");
debug!("PipeWire enumeration returned None");
Vec::new()
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/backends/camera/pipewire/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ impl PipeWirePipeline {

// Log format info every 60 frames for debugging
if frame_num.is_multiple_of(60) {
info!(
debug!(
frame = frame_num,
width,
height,
Expand Down
Loading