"struct_lookup" action for bureaucracy #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Action allows create struct lookup entries using bureaucracy form. Syntax: <form> action struct_lookup ... </form> <form> can contain any number of struct_field or struct_schema. Data will be saved to respective lookup schemas.
|
Works well with #356 |
splitbrain
reviewed
Jan 9, 2018
helper/lookup.php
Outdated
| if (!$access instanceof AccessTableLookup) continue; | ||
|
|
||
| if(!$access->getSchema()->isEditable()) { | ||
| throw new StructException('lookup save error: no permission for schema'); |
There was a problem hiding this comment.
Does throwing a Struct Exception in the bureaucracy context work? I don't think bureaucracy is catching exceptions. Instead a msg() should be shown and false be returned.
|
can you update the docs again? thanks! |
|
Ok. No problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action allows create struct lookup entries using bureaucracy form. Syntax:
action struct_lookup ... can contain any number of struct_field or struct_schema. Data will be saved to respective lookup schemas.