-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve autocomplete search for pages #685
Conversation
Also addresses #622 by adding regex capability in new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the regex only is applied to the namespace, not the whole ID. I guess that makes sense from the name of the configuration (namespace
). More useful IMHO would be a match against the whole ID? Maybe we should think about how we could rename the config without losing existing configuration.
I am also not convinced that we need to differentiate between regex and non-regex configs. Any valid previous configuration should still be a valid regex, so why not always treat the config as regex and add the delimiters ourselves?
The suggestion makes a lot of sense. I tried to introduce a new option
Do you have an idea how to migrate a config option another way? |
Hmm maybe overwrite mergeConfig() for the Page type? |
I converted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #579 and #593