feat: skip global registration for internal generated code #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a test failure here which I think is unrelated. |
julienrbrt
approved these changes
Jun 25, 2024
This repo doesn't have a CHANGELOG 😉 . But I can add one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes proto files which are generated into
internalgo packages to not be registered with the global protobuf registries. This allows for packages to generate types which are not accessible or visible to any outside users so that they can precisely control the generation and versioning of these types without having to worry about third party consumers of these types.In the short term this can help with removing the dependency in orm on api (which is problematic because of the complex api module versioning). It can also be used for other packages depending on api like client/v2 and maybe x/tx.
ref cosmos/cosmos-sdk#11802