-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: OpenTelemetry configuration and BaseApp instrumentation #25516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,645
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lint failing just on deprecated fields |
Contributor
should be fixed |
aljo242
approved these changes
Dec 5, 2025
Member
Author
|
Guess what? otelconf just did a new release upstream: https://pkg.go.dev/go.opentelemetry.io/contrib/otelconf |
aljo242
approved these changes
Dec 10, 2025
warpbuild-benchmark-bot bot
added a commit
to WarpBuilds/cosmos-sdk
that referenced
this pull request
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:x/auth
C:x/bank
C:x/distribution
distribution module related
C:x/epochs
C:x/evidence
C:x/genutil
genutil module issues
C:x/gov
C:x/mint
C:x/protocolpool
C:x/slashing
C:x/staking
C:x/upgrade
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
telemetry/package via https://pkg.go.dev/go.opentelemetry.io/contrib/otelconf/v0.3.0telemetry/which are based on https://pkg.go.dev/github.com/hashicorp/go-metrics which is under-maintained and requires mutex locks and map lookups on every telemetry methodBaseAppwith OpenTelemetry spans and block and tx counter metricsTestingMainfunction for tests to export telemetry dataconfigures thelog/slogdefault logger to send logs to OpenTelemetry and allows otelslog bridged to be used for logging. NOTE: this leaves a bit of a disconnect between the SDK's existing logging infrastructure which currently just writes to stdout - this can either be default with in this PR or dealt with in a follow upThe OpenTelemetry go libraries are very actively maintained, most vendors in the space are adding OpenTelemetry support and generally it seems like the industry is headed in this direction. Much of our existing telemetry code is to configure basic telemetry exporting, but with otelconf declarative config, we don't need to maintain any of this ourselves and the out of the box experience is quite simple even for usage in testing.
Closes: SDK-427