-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(math): reset Int state when Unmarshal sees empty input #25568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(math): reset Int state when Unmarshal sees empty input #25568
Conversation
|
can you show why this is needed? |
|
@aljo242 added test without the fix, the test fails: If I had to briefly answer why this is needed: the old code does |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25568 +/- ##
==========================================
+ Coverage 68.39% 70.50% +2.11%
==========================================
Files 856 826 -30
Lines 55855 54712 -1143
==========================================
+ Hits 38201 38576 +375
+ Misses 17654 16136 -1518
🚀 New features to boost your workflow:
|
Int.Unmarshalimplementation so empty byte slices zero the value instead of discarding the receiver pointer