-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(x/mint): Add max supply param (backport #19896) #25599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Marko <[email protected]> remove cherry-pick commet errors fix test fix v3 migrate simplify the condition cleanup logic Problem: minted coin could be negative Solution: - stop minting if total supply already exceeds max supply
|
@yihuang CI is broken |
I'm not sure how to handle the api package dependency, if we replace it to local directory, it'll complain |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25599 +/- ##
==========================================
- Coverage 70.42% 70.42% -0.01%
==========================================
Files 830 831 +1
Lines 54052 54081 +29
==========================================
+ Hits 38068 38087 +19
- Misses 15984 15994 +10
🚀 New features to boost your workflow:
|
|
is merged so the api diff should be fixed - needs a changelog |
I think we still need to merge the api changes first right? (#25612) Otherwise if I replace api to relative directory: I'll get: |
|
I think it makes sense to include the api changes directly here |
Description
Co-authored-by: Marko [email protected]