Skip to content

Conversation

@yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 10, 2025

Description

Closes: #628


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@yihuang yihuang changed the title Problem: events emitted in hooks are duplicated fix: events emitted in hooks are duplicated Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.19%. Comparing base (3225549) to head (c208f44).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
+ Coverage   64.96%   65.19%   +0.22%     
==========================================
  Files         317      317              
  Lines       21604    21597       -7     
==========================================
+ Hits        14036    14080      +44     
- Misses       6349     6356       +7     
+ Partials     1219     1161      -58     
Files with missing lines Coverage Δ
x/vm/keeper/state_transition.go 83.55% <ø> (-0.22%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

postProcessing: func(ctx sdk.Context, sender common.Address, msg core.Message, receipt *gethtypes.Receipt) error {
ctx.EventManager().EmitEvent(
sdk.NewEvent(
"test_post_processing_event",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this a const?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double Event Emit due to Misuse of CacheContext

2 participants