Add Fee-Abstraction to Hub #3141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoank101
requested review from
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
# Conflicts: # ante/ante.go # app/app.go # app/keepers/keepers.go # app/keepers/keys.go # app/modules.go # go.mod # x/globalfee/ante/antetest/fee_test_setup.go # x/globalfee/ante/fee.go
# Conflicts: # ante/ante.go
|
hi @mpoke can you review PR? |
|
all test pass |
|
Would you mind explaining how you tested this feature? I don't see any additions to the integration or e2e tests. The tests are passing because the feature added in this PR is is never triggered or it is not confirmed that it is getting triggered correctly. |
Thank you for your feedback. I will add more tests for feeabs. Currently, it passes the original Gaia test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Fee-abstraction module to the Hub
Follow by Proposal 810
This PR will:
Old PR #2702