fix: fix GIT_DIFF in the docker workflow. #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastfadingviolets
requested review from
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
fastfadingviolets
force-pushed
the
docker-git-diff
branch
2 times, most recently
from
072a76e
to
b882004
Compare
It turns out the get-diff-action only works on `push` and `pull_request` events, and will report an empty diff otherwise. This makes it so that we only run nightly builds if there's been a commit in the last 24h. Builds from workflow_dispatch and releases are always triggered.
fastfadingviolets
force-pushed
the
docker-git-diff
branch
from
b882004
to
16d549c
Compare
sainoe
approved these changes
Jul 15, 2024
fastfadingviolets
added a commit
to fastfadingviolets/gaia
that referenced
this pull request
Jul 16, 2024
It turns out the get-diff-action only works on `push` and `pull_request` events, and will report an empty diff otherwise. This makes it so that we only run nightly builds if there's been a commit in the last 24h. Builds from workflow_dispatch and releases are always triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out the get-diff-action only works on
pushandpull_requestevents, and will report an empty diff otherwise. This makes it so that we only run nightly builds if there's been a commit in the last 24h. Builds from workflow_dispatch and releases are always triggered.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)