chore: bump version to v20 #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoke
requested review from
dasanchez,
LexaMichaelides,
fastfadingviolets,
a team,
zmanian,
crodriguezvega and
jackzampolin
as code owners
insumity
reviewed
Aug 6, 2024
insumity
reviewed
Aug 6, 2024
insumity
reviewed
Aug 6, 2024
insumity
reviewed
Aug 6, 2024
insumity
reviewed
Aug 6, 2024
|
This PR seems to be doing more than just chores. I wonder if we should change its type? |
|
I reverted the changes I made, see 25197b1 |
* Upgrade ICS version * Change app wiring * Add migration * Fix linting * Add initialization for LastProviderConsensusValSet * Use CamelCase for const names * Remove unnecessary migration and parameter check * Adjust comment to mention LastProviderConsensusValidatorSet initialization * Remove panics and replace with error returns * Improve logging * Lint
|
Oops, my instinct for merging PRs as soon as they have two approvals took over and I merged the PR into this branch again... I'll untangle this on Monday |
p-offtermatt
approved these changes
Aug 14, 2024
insumity
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...