chore: add tests for Channel.Validate (#7504)

* chore: add tests for Channel.Validate * Update modules/core/04-channel/v2/types/channel_test.go Co-authored-by: DimitrisJim <[email protected]> * Update modules/core/04-channel/v2/types/channel_test.go Co-authored-by: DimitrisJim <[email protected]> --------- Co-authored-by: DimitrisJim <[email protected]>
cosmos · Oct 22, 2024 · 60f20f0 · 60f20f0
1 parent 8b7889c
commit 60f20f0
Showing 1 changed file with 58 additions and 0 deletions.
diff --git a/modules/core/04-channel/v2/types/channel_test.go b/modules/core/04-channel/v2/types/channel_test.go
@@ -0,0 +1,58 @@
+package types_test
+
+import (
+	"github.com/cosmos/ibc-go/v9/modules/core/04-channel/v2/types"
+	host "github.com/cosmos/ibc-go/v9/modules/core/24-host"
+	ibctesting "github.com/cosmos/ibc-go/v9/testing"
+)
+
+func (s *TypesTestSuite) TestValidateChannel() {
+	var c types.Channel
+	testCases := []struct {
+		name     string
+		malleate func()
+		expErr   error
+	}{
+		{
+			name:     "success",
+			malleate: func() {},
+		},
+		{
+			name: "failure: invalid ClientID",
+			malleate: func() {
+				c.ClientId = ""
+			},
+			expErr: host.ErrInvalidID,
+		},
+		{
+			name: "failure: invalid counterparty channel id",
+			malleate: func() {
+				c.CounterpartyChannelId = ""
+			},
+			expErr: host.ErrInvalidID,
+		},
+		{
+			name: "failure: invalid Merkle Path Prefix",
+			malleate: func() {
+				c.MerklePathPrefix.KeyPath = [][]byte{}
+			},
+			expErr: types.ErrInvalidChannel,
+		},
+	}
+	for _, tc := range testCases {
+		s.Run(tc.name, func() {
+			c = types.NewChannel(ibctesting.FirstClientID, ibctesting.SecondClientID, ibctesting.MerklePath)
+
+			tc.malleate()
+
+			err := c.Validate()
+
+			expPass := tc.expErr == nil
+			if expPass {
+				s.Require().NoError(err)
+			} else {
+				ibctesting.RequireErrorIsOrContains(s.T(), err, tc.expErr)
+			}
+		})
+	}
+}