Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid invalid identifier error when validate genesis (backport #7397) #7404

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024

that contains localhost client

Description

closes: #7396


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

This is an automatic backport of pull request #7397 done by [Mergify](https://mergify.com).

* fix: avoid invalid identifier error when validate genesis

that contains localhost client

* Apply suggestions from code review

* skip

(cherry picked from commit ff2b668)

# Conflicts:
#	CHANGELOG.md
Copy link
Contributor Author

mergify bot commented Oct 7, 2024

Cherry-pick of ff2b668 has failed:

On branch mergify/bp/release/v9.0.x/pr-7397
Your branch is up to date with 'origin/release/v9.0.x'.

You are currently cherry-picking commit ff2b668c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/core/03-connection/types/genesis.go
	modified:   modules/core/03-connection/types/genesis_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@colin-axner colin-axner self-assigned this Oct 7, 2024
@colin-axner colin-axner removed their assignment Oct 7, 2024
Copy link

sonarcloud bot commented Oct 7, 2024

@colin-axner colin-axner merged commit fca10d9 into release/v9.0.x Oct 8, 2024
20 checks passed
@colin-axner colin-axner deleted the mergify/bp/release/v9.0.x/pr-7397 branch October 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants