chore: clean up ProvideCounterparty tx. #7422
Merged
+78
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
commented
Oct 9, 2024
| counterparty, found := suite.chainA.App.GetIBCKeeper().PacketServerKeeper.GetCounterparty(suite.chainA.GetContext(), path.EndpointA.ChannelID) | ||
| suite.Require().True(found) | ||
| suite.Require().Equal(counterparty, msg.Counterparty) | ||
| suite.Require().Equal(counterparty.CounterpartyChannelId, path.EndpointB.ChannelID) |
There was a problem hiding this comment.
TODO: we should do same thing we did for old chan creation flow to get unique channel identifiers. The channelIDs for both endpoints are channel-0 here.
4 tasks
Base automatically changed from
jim/test-runs-create-channel
to
feat/ibc-eureka
October 9, 2024 13:17
DimitrisJim
force-pushed
the
jim/trim-down-provide-counterparty-proto
branch
from
c863257
to
d206c5b
Compare
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
crodriguezvega,
gjermundgaraba and
bznein
as code owners
Co-authored-by: Aditya <[email protected]>
damiannolan
approved these changes
Oct 9, 2024
4 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove uneeded fields which were made obsolete by the CreateChannel tx. Follow up to #7420
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.