Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize Vec push avoid realloc mem #1374

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Oct 31, 2024

Description

optimize Vec push avoid realloc mem


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.87%. Comparing base (5bba36e) to head (8041036).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/ics721-nft-transfer/src/handler/send_transfer.rs 0.00% 10 Missing ⚠️
.../ics721-nft-transfer/src/handler/on_recv_packet.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
- Coverage   66.88%   66.87%   -0.02%     
==========================================
  Files         225      225              
  Lines       22617    22622       +5     
==========================================
+ Hits        15127    15128       +1     
- Misses       7490     7494       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nkysg for the improvement, and your first contribution!

@nkysg
Copy link
Contributor Author

nkysg commented Nov 12, 2024

Thanks for help @rnbguy @Farhad-Shabani

@rnbguy rnbguy changed the title optimize Vec push avoid realloc mem refactor: optimize Vec push avoid realloc mem Nov 12, 2024
@rnbguy rnbguy added this pull request to the merge queue Nov 12, 2024
Merged via the queue into cosmos:main with commit e0451ae Nov 12, 2024
13 checks passed
@nkysg nkysg deleted the opt_vec_push branch November 12, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants