-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make process()
functions pub(crate)
#328
Conversation
Codecov ReportBase: 62.96% // Head: 63.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 62.96% 63.69% +0.72%
==========================================
Files 124 124
Lines 13931 13773 -158
==========================================
+ Hits 8772 8773 +1
+ Misses 5159 5000 -159
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for handling this one @DaviRain-Su
Because this pub trait ValidationContext {
/// Validation entrypoint.
fn validate(&self, message: MsgEnvelope) -> Result<(), RouterError>
where
Self: Sized,
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 tiny changes left, and we're ready to merge
@@ -14,6 +14,7 @@ pub mod misbehaviour; | |||
pub mod update_client; | |||
pub mod upgrade_client; | |||
|
|||
#[allow(dead_code)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this anymore, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,2 @@ | |||
- Make Msg* structs pub(crate) ([#324](https://github.com/cosmos/ibc- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update this when merging #327.
process()
functions pub(crate)
Closes: #338
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.