Skip to content

Commit

Permalink
fix callbacks
Browse files Browse the repository at this point in the history
  • Loading branch information
sangier committed Oct 31, 2024
1 parent 6968864 commit 8434128
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions spec/core/v2/ics-004-channel-and-packet-semantics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ function recvPacket(
// Executes Application logic ∀ Payload
payload=packet.data[0]
cbs = router.callbacks[payload.destPort]
ack,success = cbs.onReceivePacket(packet.channelDestId,payload,relayer,packet.sequence) // Note that payload includes the version. The application is required to inspect the version to route the data to the proper callback
ack,success = cbs.onReceivePacket(packet.channelDestId,packet.channelSourceId,packet.sequence,payload,relayer) // Note that payload includes the version. The application is required to inspect the version to route the data to the proper callback
abortTransactionUnless(success)
if ack != nil {
// NOTE: Synchronous ack.
Expand Down Expand Up @@ -852,7 +852,7 @@ function acknowledgePacket(
// Executes Application logic ∀ Payload
payload=packet.data[0]
cbs = router.callbacks[payload.sourcePort]
success= cbs.OnAcknowledgePacket(packet.channelSourceId,payload,packet.sequence,acknowledgement, relayer) // Note that payload includes the version. The application is required to inspect the version to route the data to the proper callback
success= cbs.OnAcknowledgePacket(packet.channelSourceId,packet.channelDestId,packet.sequence,payload,acknowledgement, relayer) // Note that payload includes the version. The application is required to inspect the version to route the data to the proper callback
abortUnless(success)
}

Expand Down Expand Up @@ -971,7 +971,7 @@ function timeoutPacket(

payload=packet.data[0]
cbs = router.callbacks[payload.sourcePort]
success=cbs.OnTimeoutPacket(packet.channelSourceId,payload,packet.sequence) // Note that payload includes the version. The application is required to inspect the version to route the data to the proper callback
success=cbs.OnTimeoutPacket(packet.channelSourceId,packet.channelDestId,packet.sequence,payload,relayer) // Note that payload includes the version. The application is required to inspect the version to route the data to the proper callback
abortUnless(success)

channelStore.delete(packetCommitmentPath(packet.channelSourceId, packet.sequence))
Expand Down

0 comments on commit 8434128

Please sign in to comment.