Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet Spec: Hash App data rather than standardizing encoding #1152

Merged
merged 9 commits into from
Nov 11, 2024

Conversation

AdityaSripal
Copy link
Member

The following is the Packet spec that uses only hashing rather than the cbor encoding in the previous spec. This is meant to allow reviewers to compare the two options.

Benefits:

  • No standardized encoding allows implementation by virtually any platform with low maintanence burden
  • Canonical by construction

Cons:

  • Must specify a unique commitment scheme for the internal packet data and acknowledgement rather than relying on existing encoding
  • Multiple hashes might be slow and expensive in certain environments (e.g. EVM, and ZKVM)

@AdityaSripal AdityaSripal changed the base branch from main to feat/v2-spec October 11, 2024 14:55
@sangier
Copy link
Contributor

sangier commented Oct 23, 2024

Dropping some thoughts about the cons: "Multiple hashes might be slow and expensive in certain environments (e.g. EVM, and ZKVM)"

  • Checking the ethereum yellow paper I noticed that a simple transfer cost 21,000 gas, while a keccak256 encoding only costs 30 gas for the first 32 bytes, and 6 gas for each additional 32 bytes. Thus at least for EVM environment multiple hashes are not expensive and should be fast as keccack is the native enconding function.
  • The multiple hashes may affect the zkvm proof generation and verification processes, but I'm not sure how.
  • The native encoding function for Solana is sha-256.
  • Cairo uses natively Poseidon and Pedersen which are zk-snark friendly.

So, intra-platform (e.g. Cosmos to Cosmos, EVM to EVM, Sol to Sol ...) we could use the native hashing functions being fast and cheap. However inter-platform (e.g EVM to Solana..) we must use one hashing function and use it in both the environments, which may affect the computation of one of the side.

spec/core/v2/ics-004-packet-semantics/PACKET.md Outdated Show resolved Hide resolved
}
buffer = sha256.Hash(destIdentifier)
buffer = append(buffer, sha256.hash(bigEndian(timeoutBytes)))
buffer = append(buffer, sha256.hash(data))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buffer = append(buffer, sha256.hash(data))
buffer = append(buffer, sha256.hash(packet.data))

spec/core/v2/ics-004-packet-semantics/PACKET.md Outdated Show resolved Hide resolved
@AdityaSripal AdityaSripal merged commit 1269ed6 into feat/v2-spec Nov 11, 2024
2 checks passed
@AdityaSripal AdityaSripal deleted the aditya/hash-packet-spec branch November 11, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants