Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS4: Create 32 byte commitment #1168

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Conversation

AdityaSripal
Copy link
Member

Closes: #1167

Creates fixed 32-byte commitment by moving protocol byte into the final hash to improve gas costs on solidity

@AdityaSripal AdityaSripal changed the base branch from main to feat/v2-spec November 14, 2024 12:33
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swift!

spec/core/v2/ics-004-packet-semantics/PACKET.md Outdated Show resolved Hide resolved
@AdityaSripal AdityaSripal merged commit 0e28624 into feat/v2-spec Nov 18, 2024
2 checks passed
@AdityaSripal AdityaSripal deleted the aditya/32-commitment branch November 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

ICS4: Create 32-byte commitments
3 participants