Repository navigation
Conversation
Contributor
Greptile SummaryThis PR adds a local two-chain Besu QBFT demonstration with generated genesis configurations, account derivation, Docker Compose orchestration, and operational documentation.
Confidence Score: 3/5The PR is not yet safe to merge because the previously reported validator-key exposure remains unresolved. The generated validator key is still written mode 0644 beneath mode-0755 directories, so an unrelated local user can read a custom mnemonic’s sole-validator key and impersonate that validator. Files Needing Attention: examples/besu-to-besu/lib/chains.sh Important Files Changed
|
Contributor
Author
|
@greptile review |
Contributor
Author
|
@greptile review |
Contributor
Author
|
@greptile review |
dhfang
reviewed
Aug 11, 2026
Signed-off-by: Diana Borbe <diana@cosmoslabs.io>
Signed-off-by: Diana Borbe <diana@cosmoslabs.io>
Signed-off-by: Diana Borbe <diana@cosmoslabs.io>
Signed-off-by: Diana Borbe <diana@cosmoslabs.io>
A dummy-client deploy in TestStartRealizesAppStackAndDummyClients hung in bind.WaitMined for 9+ minutes on CI until the go test 10m alarm killed the whole package: nothing bounded the wait, and WaitMined polls forever while swallowing every receipt error. Bound each setup transaction wait with the chain's CompletionBudget, so a lost transaction fails its own test in bounded time with a stage-named error instead of panicking the test binary. Note for future work: evm.EVMClient.waitForReceipt fails on the first transport error; geth-style nodes emit a transient, string-only "transaction indexing is in progress" receipt error right after mining, so reusing that helper here would need its error handling revisited. Signed-off-by: Diana Borbe <diana@cosmoslabs.io>
Signed-off-by: Diana Borbe <diana@cosmoslabs.io>
Signed-off-by: Diana Borbe <diana@cosmoslabs.io>
Signed-off-by: Diana Borbe <diana@cosmoslabs.io>
dianab-cl
force-pushed
the
diana/fou-1225-create-script-to-launch-two-besu-chains-locally
branch
from
August 11, 2026 19:18
c2c9db5 to
7c0da14
Compare
…esu-chains-locally
…esu-chains-locally
dhfang
approved these changes
Aug 12, 2026
…esu-chains-locally
Signed-off-by: Dennis Fang <dhsfang@gmail.com>
…esu-chains-locally Signed-off-by: dhfang <dhsfang@gmail.com>
dhfang
deleted the
diana/fou-1225-create-script-to-launch-two-besu-chains-locally
branch
August 13, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.