-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: enable unjail on pre-ccv chains #2396
Draft
MSalopek
wants to merge
4
commits into
main
Choose a base branch
from
masa/unjail-ops-preccv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,8 +84,13 @@ func (k Keeper) IterateValidators(context.Context, func(index int64, validator s | |
return nil | ||
} | ||
|
||
// Validator - unimplemented on CCV keeper | ||
func (k Keeper) Validator(ctx context.Context, addr sdk.ValAddress) (stakingtypes.ValidatorI, error) { | ||
// Validator - unimplemented on CCV keeper but implemented on standalone keeper | ||
func (k Keeper) Validator(sdkCtx context.Context, addr sdk.ValAddress) (stakingtypes.ValidatorI, error) { | ||
ctx := sdk.UnwrapSDKContext(sdkCtx) | ||
if k.IsPrevStandaloneChain(ctx) && k.ChangeoverIsComplete(ctx) && k.standaloneStakingKeeper != nil { | ||
return k.standaloneStakingKeeper.Validator(ctx, addr) | ||
} | ||
|
||
panic("unimplemented on CCV keeper") | ||
} | ||
|
||
|
@@ -174,15 +179,23 @@ func (k Keeper) SlashWithInfractionReason(goCtx context.Context, addr sdk.ConsAd | |
// the provider validator set will soon be in effect, and jailing is n/a. | ||
func (k Keeper) Jail(context.Context, sdk.ConsAddress) error { return nil } | ||
|
||
// Unjail - unimplemented on CCV keeper | ||
// Unjail is enabled for previously standalone chains after the changeover is complete. | ||
// | ||
// This method should be a no-op even during a standalone to consumer changeover. | ||
// Once the upgrade has happened as a part of the changeover, | ||
// the provider validator set will soon be in effect, and jailing is n/a. | ||
func (k Keeper) Unjail(context.Context, sdk.ConsAddress) error { return nil } | ||
// This method should be a no-op for consumer chains that launched with the CCV module first. | ||
func (k Keeper) Unjail(sdkCtx context.Context, addr sdk.ConsAddress) error { | ||
ctx := sdk.UnwrapSDKContext(sdkCtx) | ||
if k.IsPrevStandaloneChain(ctx) && k.ChangeoverIsComplete(ctx) && k.standaloneStakingKeeper != nil { | ||
return k.standaloneStakingKeeper.Unjail(ctx, addr) | ||
} | ||
return nil | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Return an error instead of nil. |
||
} | ||
|
||
// Delegation - unimplemented on CCV keeper | ||
func (k Keeper) Delegation(ctx context.Context, addr sdk.AccAddress, valAddr sdk.ValAddress) (stakingtypes.DelegationI, error) { | ||
// Delegation - unimplemented on CCV keeper but implemented on standalone keeper | ||
func (k Keeper) Delegation(sdkCtx context.Context, addr sdk.AccAddress, valAddr sdk.ValAddress) (stakingtypes.DelegationI, error) { | ||
ctx := sdk.UnwrapSDKContext(sdkCtx) | ||
if k.IsPrevStandaloneChain(ctx) && k.ChangeoverIsComplete(ctx) && k.standaloneStakingKeeper != nil { | ||
return k.standaloneStakingKeeper.Delegation(ctx, addr, valAddr) | ||
} | ||
panic("unimplemented on CCV keeper") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Return an error instead of panicking. |
||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return an error instead of panicking.