Dev #95
Merged
Dev #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chcmedeiros
force-pushed
the
dev
branch
3 times, most recently
from
dfc1d88 to
36894b6
Compare
ftheirs
reviewed
Sep 14, 2023
app/src/parser.c
Outdated
| } | ||
|
|
||
| if (strlen(COIN_DEFAULT_DENOM_BASE) != denom_len) { | ||
| return bool_false; | ||
| *is_default = bool_false; |
There was a problem hiding this comment.
Can we replace this custom type and just use true/false? There are several parts that bool_t is used
ftheirs
reviewed
Sep 14, 2023
ftheirs
reviewed
Sep 14, 2023
ftheirs
reviewed
Sep 14, 2023
ftheirs
force-pushed
the
dev
branch
3 times, most recently
from
68c9935 to
9253160
Compare
chcmedeiros
force-pushed
the
dev
branch
3 times, most recently
from
177790e to
9c642fd
Compare
ftheirs
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.