Skip to content
This repository was archived by the owner on Apr 10, 2026. It is now read-only.

fix: fetch gas-prices from the chain config if provided#1508

Merged
reecepbcups merged 1 commit intocosmos:mainfrom
freak12techno:fix-chain-registry-gas-price-fetching
Oct 15, 2024
Merged

fix: fetch gas-prices from the chain config if provided#1508
reecepbcups merged 1 commit intocosmos:mainfrom
freak12techno:fix-chain-registry-gas-price-fetching

Conversation

@freak12techno
Copy link
Copy Markdown
Contributor

@freak12techno freak12techno commented Oct 12, 2024

Fixes #1507

The behaviour should be backwards-compatible:

  • if fees.fee_tokens is not empty, we use it
  • if it is empty, we fetch assets list and set the denom/gas price from it, if it's present (same way as before)
  • if asset list is also empty, we do not set it at all (same way as before)

@freak12techno freak12techno requested a review from a team October 12, 2024 12:34
@freak12techno
Copy link
Copy Markdown
Contributor Author

@reecepbcups can you take a look?

Copy link
Copy Markdown
Contributor

@reecepbcups reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reecepbcups reecepbcups merged commit 6a22c2b into cosmos:main Oct 15, 2024
@freak12techno freak12techno deleted the fix-chain-registry-gas-price-fetching branch October 15, 2024 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When fetching chain from chain-registry, gas-prices are calculated incorrectly

2 participants