-
Notifications
You must be signed in to change notification settings - Fork 8
Update tutorial-sync-gateway-manage.adoc #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iamfortune
wants to merge
5
commits into
release/2.8
Choose a base branch
from
DOC-10860-add-auth-headers
base: release/2.8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5706898
Update tutorial-sync-gateway-manage.adoc
iamfortune 2d1b1b3
Merge branch 'release/2.8' into DOC-10860-add-auth-headers
osfameron 69277c2
check tech-comm-team-couchbase
osfameron 5bd283e
Update tutorial-sync-gateway-manage.adoc
iamfortune 10185a1
Update tutorial-sync-gateway-manage.adoc
iamfortune File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop this line, I'd always expect that especially k8s uses are using admin authentication. If they aren't using authentication (this should never be the case!) then setting a an authorization header is unnecessary.
Especially because this is k8s documentation and they are more likely to have the correct certifcation information, I would have the SG urls always use
https, so a find and replace onhttp://localhost:4985tohttps://localhost:4985would be appropriate.I even think using tls for non Sync Gateway documentation is correct because folks should always configure Sync Gateway with TLS, and you have to really opt out to do this.
admin_interface_authenticationis true by default.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes to the file.