CBG-3813 add insertion strings to capture stdout/stderr #6719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcfraser
approved these changes
Mar 7, 2024
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stderr/stdout are logged from https://github.com/couchbase/sync_gateway/blob/release/3.1.3/service/sg-windows/sg-service/sg-service.go#L55 which forwards events to the windows event log.
It will return
MessageasIncorrect Functionas per golang/go#45086. A proposal to fix the code in golang.org/x/sys/windows/svc/eventlog is in golang/go#59780 but it would be hard to implement for our use case.I left
Messagefield present in case it is useful, which it might be for events that are not Sync Gateway events. I could drop it formake_event_log_task_sg_infobecauseIncorrect Functionlooks like an error but it is not.