Skip to content

Conversation

torcolvin
Copy link
Collaborator

No description provided.

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 14:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the test comments in a Sync Gateway replication test to improve clarity and formatting. The changes modify ASCII table comments that document the expected behavior for conflict resolution scenarios during replication between nodes with different version capabilities.

Key Changes

  • Reformatted ASCII table comments for better readability and alignment
  • Updated HLV (Hybrid Logical Vector) expected values to be more specific and accurate
  • Improved column spacing and structure in the test case documentation

// +-----------------+-------------+-------------------------------+-------------+--------------------------------+
// | Initial State | 2-abc,1-abc | none | 2-def,1-abc | 100@SGW2 |
// +-----------------+-------------+-------------------------------+-------------+--------------------------------+
// | Expected Result | 2-def,1-abc | 1100@SGW2;2def@RTE;oldcas@SGW1| 2-def,1-abc | 1100@SGW2;2def@RTE;oldcas@SGW1 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we need to swap the sources for SGW1 and SGW2 given for this test case we update the doc on active peer (SGW1) on line 1005. So I think this needs to be 1100@SGW1;2def@RTE,oldcas@SGW2

@gregns1 gregns1 assigned torcolvin and unassigned gregns1 Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants