-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSCBC-1: Implement HTTP Crate #177
Conversation
This is great. It might be a good idea to move the integration tests to the top level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me, just the minor thing about #[non_exhaustive] so that expanding request blocks aren't breaking changes in the future. In the future we might want to think about using hyper but this shields any upstream crates from that too.
Changes