Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSCBC-1: Implement HTTP Crate #177

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

Matt-Woz
Copy link

Changes

  • Created HTTP Client, wrapping reqwest
  • Created custom JSON Row parser + stream

@chvck
Copy link
Collaborator

chvck commented Aug 22, 2024

This is great. It might be a good idea to move the integration tests to the top level tests crate and think about how we can add an abstraction layer between us and reqwest. That'd both decouple us a bit and let us unit test more easily.

sdk/couchbase-core/src/httpx/base.rs Outdated Show resolved Hide resolved
sdk/couchbase-core/src/httpx/base.rs Outdated Show resolved Hide resolved
sdk/couchbase-core/src/httpx/base.rs Outdated Show resolved Hide resolved
sdk/couchbase-core/src/httpx/base.rs Outdated Show resolved Hide resolved
sdk/couchbase-core/src/httpx/client.rs Show resolved Hide resolved
sdk/couchbase-core/src/httpx/json_block_read.rs Outdated Show resolved Hide resolved
sdk/couchbase-core/src/httpx/json_row_parser.rs Outdated Show resolved Hide resolved
sdk/couchbase-core/src/httpx/raw_json_row_streamer.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@chvck chvck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me, just the minor thing about #[non_exhaustive] so that expanding request blocks aren't breaking changes in the future. In the future we might want to think about using hyper but this shields any upstream crates from that too.

sdk/couchbase-core/src/httpx/base.rs Show resolved Hide resolved
sdk/couchbase-core/src/httpx/client.rs Outdated Show resolved Hide resolved
@Matt-Woz Matt-Woz merged commit 3ad50cb into couchbaselabs:nativex Sep 3, 2024
9 checks passed
@Matt-Woz Matt-Woz deleted the httpx branch September 3, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants