Support multi-select fields for the region selection #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheeyls
force-pushed
the
multi-select-regions
branch
from
871065d
to
f0c6298
Compare
benkeen
reviewed
May 30, 2018
source/source-crs.js
Outdated
| if (currVal === val) { | ||
| field.selectedIndex = (_showEmptyRegionOption) ? i + 1 : i; | ||
| console.log(currVal, val); |
There was a problem hiding this comment.
The debugging code can get removed.
|
Interesting feature! Yeah I can see this being useful. |
wheeyls
force-pushed
the
multi-select-regions
branch
from
f0c6298
to
c485c2f
Compare
wheeyls
force-pushed
the
multi-select-regions
branch
from
c485c2f
to
7c7b9be
Compare
|
Sorry for the long delay. I've been using my branch live in a project and just realized you'd commented on this change recently. Updated my PR with correct tabbing, and resolved conflicts w/ master. My only concern is that I didn't test the jquery version, only the vanilla JS one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.