feat(code-editor): support custom tabSize #4014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow setting a custom
tabSize
in theCodeEditor
component.Previously, it was hardcoded to
2
but let's say for example you use the editor to write Python code and want to follow thePEP8
guidelines, you need to set4
.Demo here. 🧪
Documentation
📖 This prop is supported by the
Monaco Editor
and documented here.tabSize
:So this means that if you set a
tabSize
of 4, but the content of the editor is using 2 spaces, it will enforce atabSize
of 2. However, if you erase everything and start from scratch, it will fallback on thetabSize
property.Potential Breaking Changes
None. The new prop is optional and the default behaviour with a
tabSize
of 2 is preserved.Acceptance Criteria