applied improvements

coveo · Feb 19, 2025 · ee0eea3 · ee0eea3
1 parent 3f5e0e0
commit ee0eea3
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 19 deletions.
diff --git a/...ic/force-app/examples/main/lwc/exampleQuanticFacetManager/exampleQuanticFacetManager.html b/...ic/force-app/examples/main/lwc/exampleQuanticFacetManager/exampleQuanticFacetManager.html
@@ -20,6 +20,7 @@
           <c-quantic-timeframe unit="year"></c-quantic-timeframe>
         </c-quantic-timeframe-facet>
         <c-quantic-facet engine-id={engineId} field="objecttype" label="Type"></c-quantic-facet>
+        <div slot="itemTemplate" class="slds-m-around_xx-large"></div>
       </c-quantic-facet-manager>
     </c-example-use-case>
   </c-example-layout>

diff --git a/packages/quantic/force-app/main/default/lwc/quanticFacetManager/e2e/pageObject.ts b/packages/quantic/force-app/main/default/lwc/quanticFacetManager/e2e/pageObject.ts
@@ -10,14 +10,14 @@ export class FacetManagerObject {
   }
 
   get facetManagerItems(): Locator {
-    return this.facetManager.locator('.facet-manager__item');
+    return this.facetManager.getByTestId('facet-manager__item');
   }
 
-  getFacetManagerItemByIndex(index: number): Locator {
-    return this.facetManagerItems.nth(index);
+  get itemTemplateSlot(): Locator {
+    return this.facetManager.locator('slot[name="itemTemplate"]');
   }
 
-  getAllFacetManagerItems(): Promise<Locator[]> {
-    return this.facetManager.locator('.facet-manager__item').all();
+  getFacetManagerItemByIndex(index: number): Locator {
+    return this.facetManagerItems.nth(index);
   }
 }
diff --git a/...ges/quantic/force-app/main/default/lwc/quanticFacetManager/e2e/quanticFacetManager.e2e.ts b/...ges/quantic/force-app/main/default/lwc/quanticFacetManager/e2e/quanticFacetManager.e2e.ts
@@ -52,20 +52,18 @@ useCaseTestCases.forEach((useCase) => {
         await search.performSearch();
 
         const searchResponse = await searchResponsePromise;
-        const searchResponseBody = await searchResponse.json();
-        expect(searchResponseBody).not.toBeNull();
+        const {facets} = await searchResponse.json();
+        expect(facets).not.toBeNull();
 
-        searchResponseBody?.facets?.forEach(
-          async (facet: any, index: number) => {
-            const facetManagerItem =
-              facetManager.getFacetManagerItemByIndex(index);
-            expect(
-              await facetManagerItem.getAttribute('data-facet-id')
-            ).toEqual(facet.facetId);
-          }
-        );
+        facets?.forEach(async (facet: any, index: number) => {
+          const facetManagerItem =
+            facetManager.getFacetManagerItemByIndex(index);
+          expect(await facetManagerItem.getAttribute('data-facet-id')).toEqual(
+            facet.facetId
+          );
+        });
 
-        [exampleFacetsOrder.length - 1].forEach(async (index: number) => {
+        exampleFacetsOrder.forEach(async (facetId: string, index: number) => {
           const facetManagerItem =
             facetManager.getFacetManagerItemByIndex(index);
           expect(await facetManagerItem.getAttribute('data-facet-id')).toEqual(
@@ -74,5 +72,19 @@ useCaseTestCases.forEach((useCase) => {
         });
       });
     });
+
+    test.describe('when an itemTemplate slot is provided', () => {
+      test('should customize the element that wraps each facet according to the itemTemplate slot', async ({
+        facetManager,
+      }) => {
+        const expectedClass = 'slds-m-around_xx-large';
+        expect(facetManager.itemTemplateSlot).not.toBeNull();
+
+        const facetManagerItems = await facetManager.facetManagerItems.all();
+        facetManagerItems.forEach(async (item: any) => {
+          expect(await item.getAttribute('class')).toContain(expectedClass);
+        });
+      });
+    });
   });
 });
diff --git a/packages/quantic/force-app/main/default/lwc/quanticFacetManager/quanticFacetManager.js b/packages/quantic/force-app/main/default/lwc/quanticFacetManager/quanticFacetManager.js
@@ -121,6 +121,7 @@ export default class QuanticFacetManager extends LightningElement {
       // @ts-ignore
       wrapper.setAttribute('data-facet-id', facet.facetId ?? facet.field);
       wrapper.classList.add('facet-manager__item');
+      wrapper.setAttribute('data-testid', 'facet-manager__item');
 
       wrapper.appendChild(facet);
       this.host.appendChild(wrapper);

diff --git a/packages/quantic/playwright/page-object/searchObject.ts b/packages/quantic/playwright/page-object/searchObject.ts
@@ -55,8 +55,9 @@ export class SearchObject {
       const reorderedFacets: unknown[] = [];
 
       facetIds.forEach((facetId, idx) => {
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        const facet = facets.find((f: any) => f.facetId === facetId);
+        const facet = facets.find(
+          (f: {facetId: string}) => f.facetId === facetId
+        );
         if (facet) {
           reorderedFacets.push({
             ...facet,