fix(headless): stop sending invalid actionCause for event protocol

[alexprudhomme]

https://coveord.atlassian.net/browse/KIT-3748

Stop sending to EP events that are not in that list as they are invalid. This ended up taking 20 minutes so I just did it now.

[alexprudhomme]

Here I just removed a bunch of actions that were not used.

[alexprudhomme]

I realized that instead of sending null we can simply not send any actionCause by doing executeSearch({legacy:...}) only and not executeSearch({legacy:..., next:...})

[github-actions]

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

• Storybook

• Playwright report

Bundle Size

File	Old (kb)	New (kb)	Change (%)
case-assist	241.3	241.3	0
commerce	346	346	0
search	412.9	412.4	-0.1
insight	403.6	403.5	0
recommendation	253.5	253.5	0
ssr	406.4	405.9	-0.1
ssr-commerce	358.2	358.2	0

SSR Progress

Use case	SSR (#)	CSR (#)	Progress (%)
search	39	44	89
recommendation	0	4	0
case-assist	0	6	0
insight	0	27	0
commerce	0	15	0

Detailed logs

search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

[lvu285]

Great job! I'm bit curious, after this, how we could validate if these events are valid or invalid ?

[alexprudhomme]

Great job! I'm bit curious, after this, how we could validate if these events are valid or invalid ?

If they are not in that list, they will be flagged as invalid. https://github.com/coveo-platform/analytics_schema/blob/de502f0877eeaae8e523c78a08e92222f8b26eee/schemas/common/types.json#L267-L292

[louis-bompart]

Nice job!

[louis-bompart]

Asking for @erocheleau or @mmitiche review for "insight stuff" review.

[lvu285]

Ok kk. So I assume we are not able to know until it goes to Data-platform.
(it's not urgent, you don't have to do it now, maybe next quarter) Can you please help to make sure after the fix is deployed, there is no more invalid flagged by data-platform? Or at least identify if there is anything else, maybe a jira to follow up later 🤔

Great job! I'm bit curious, after this, how we could validate if these events are valid or invalid ?

If they are not in that list, they will be flagged as invalid. https://github.com/coveo-platform/analytics_schema/blob/de502f0877eeaae8e523c78a08e92222f8b26eee/schemas/common/types.json#L267-L292

[mmitiche]

We need to update the test files under src/integration-tests/** accordingly, they are not filling becuse they are being excluded here: https://github.com/coveo/ui-kit/blob/4ccf316335e28c784e52b18d3f0c29eeddf124ba/packages/headless/package.json#L132 but they are using the functions that were deleted in this PR.

out of curiosity, what's the reason behind excluding these tests under src/integration-tests/**?