fix(headless): add globalThis shim to quanticUmd build to fix a bug with Locker Service #4701
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith Locker Service
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
|
I can attest that CI works with this branch when the Scratch org runs LWS. I will update the config to run with Locker instead and see if everything still works, I will leave it like that until we implement an LWS environment. (I'm more afraid of Locker than LWS...) |
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locker Service doesn't support
globalThisbut this was added to the library coveo.analytics.js in the last version.This meant all of Quantic components didn't load with Locker turned on.
This also made us realize that all of our Quantic test are only running with LWS and not Locker, while the SFINT package tests are running on Locker.
At least this way we cover both environments. Out of scope for this PR, but in the future we will probably revert to testing on Locker with Quantic too, and perhaps had smoke tests with LWS.
LWS being the "more recent" of the two, we expect less issues with LWS than with Locker.