feat(quantic): Allow RGA component to provide a custom "no answer" message when no answer is shown #4919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
|
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
force-pushed
the
SFINT-5926
branch
from
3a8a3c6 to
d272dc7
Compare
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
approved these changes
Feb 21, 2025
| * @example | ||
| * <c-quantic-generated-answer engine-id={engineId} with-toggle collapsible></c-quantic-generated-answer> | ||
| * <c-quantic-generated-answer engine-id={engineId} with-toggle collapsible> | ||
| * <div slot="no-answer-message">No answer was generated.</div> |
There was a problem hiding this comment.
is it slot= or name= ?
There was a problem hiding this comment.
it is slot, name is for the element :P
| return !!slot?.assignedNodes()?.length; | ||
| } | ||
|
|
||
| get shouldDisplayNoAnswerMessage() { |
There was a problem hiding this comment.
Maybe to be more specific as only a custom message would ever display a "no answer message"?
Suggested change
| get shouldDisplayNoAnswerMessage() { | |
| get shouldDisplayCustomNoAnswerMessage() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFINT-5926
IN THIS PR:
name=no-answer-messageto thequanticGeneratedAnswercomponent to display a custom error message whenever CRGA could not return an answer. If no slot is passed, we simply display nothingNotes about the solution:
cannotAnswerwas returned astrueand 2) the Quantic user has passed a named slot in the component.shouldDisplayNoAnswerMessagecheck and display the no answer HTML properly. This was the best way possible as LWC doesnt allow for conditional rendering and as it keeps the additional logic to make this feature work to a minimum in the JS file.DEMO:
Screen.Recording.2025-02-20.at.4.36.57.PM.mov
TESTS: