Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(quantic): fixed quantic timeframe facets e2e cypress test #4972

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Feb 18, 2025

SFINT-5990

The issue:

  • In Quantic Timeframe Facet where there is a date input that leverages the Salesforce date input component, when providing an invalid date, salesforce displays a validation error message, that's expected. After replacing the invalid date with a valid date, Salesforce used to completely remove the validation error message element from the dom, however now this has changed, I noticed that now they are just emptying the content of this element and they mark it as display: none with CSS.

The solution:

That was causing our test to fail as we try to count the number of validation error message elements present in the page.
I modified our selectors to only select the VISIBLE validation error message elements present in the page.

@mmitiche mmitiche requested a review from a team as a code owner February 18, 2025 01:04
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.2 244.2 0
commerce 355.5 355.5 0
search 415.5 415.5 0
insight 406.7 406.7 0
recommendation 256.3 256.3 0
ssr 409.3 409.3 0
ssr-commerce 373.2 373.2 0

@mmitiche mmitiche added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit 0a59bf6 Feb 18, 2025
102 checks passed
@mmitiche mmitiche deleted the SFINT-5990 branch February 18, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants