Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(atomic-angular): various fixes for atomic-angular generation from lit components #4982

Merged
merged 1 commit into from
Feb 18, 2025
Merged

chore(atomic-angular): various fixes for atomic-angular generation from lit components #4982

merged 1 commit into from
Feb 18, 2025

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Feb 18, 2025 •
edited
Loading

https://coveord.atlassian.net/browse/KIT-3802

works fine in my branch when I tested with atomic-commerce-pager. Here is the final result:

image

@alexprudhomme alexprudhomme requested a review from a team as a code owner February 18, 2025 20:41
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.2 244.2 0
commerce 355.5 355.5 0
search 415.5 415.5 0
insight 406.7 406.7 0
recommendation 256.3 256.3 0
ssr 409.3 409.3 0
ssr-commerce 373.2 373.2 0

@alexprudhomme alexprudhomme changed the title chore(atomic-angular): add events in lit components generation chore(atomic-angular): various fixes for atomic-angular generation from lit components Feb 18, 2025
@alexprudhomme alexprudhomme added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit 8e32def Feb 18, 2025
96 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3802 branch February 18, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-bompart louis-bompart louis-bompart approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexprudhomme @louis-bompart