Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase/demo: Tailwind v4 upgrade test setup #4983

Draft
wants to merge 3 commits into
base: building-on-windows
Choose a base branch
from

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Feb 18, 2025

This PR includes a header for the atomic examples that can be used on both this branch(with Tailwind v4 and the master branch (with Tailwind v3).

This header does a couple things:

  • Ensure that the elements in the header and outside of the atomic components are identical so that there is no layout differences.
  • Adds a custom theme toggle button to quickly compare the two branches with the default theme and a custom theme.

Some changes are known/expected:

  • Gradient on horizontal facets in the v4 branch. This gradient was actually missing before due to a bug
    image
    image

  • Added margin under product title on mobile. A bug was preventing this margin from being applied previously.
    image
    image

  • Long product descriptions not cut off anymore in mobile width. This was a bug too!

  • Color of line under tabs can be changed with --atomic-neutral.

Copy link

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.2 244.2 0
commerce 355.5 355.5 0
search 415.5 415.5 0
insight 406.7 406.7 0
recommendation 256.3 256.3 0
ssr 409.3 409.3 0
ssr-commerce 373.2 373.2 0

@fpbrault fpbrault force-pushed the demo/tailwind-v4-testing branch from 5e2c892 to 212bdc1 Compare February 18, 2025 22:10
@fpbrault fpbrault force-pushed the demo/tailwind-v4-testing branch from 212bdc1 to 9dc9a7d Compare February 18, 2025 22:30
@fpbrault fpbrault force-pushed the demo/tailwind-v4-testing branch from 9dc9a7d to 63d894d Compare February 18, 2025 22:40
@fpbrault fpbrault force-pushed the demo/tailwind-v4-testing branch from 63d894d to 1a1b8dc Compare February 19, 2025 14:46
@fpbrault fpbrault force-pushed the demo/tailwind-v4-testing branch from 1a1b8dc to d5aa2a3 Compare February 19, 2025 21:47
@fpbrault fpbrault force-pushed the demo/tailwind-v4-testing branch from 3f9dce2 to 763ad8e Compare February 20, 2025 19:05
@fpbrault fpbrault changed the base branch from KIT-3966 to building-on-windows February 20, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant