-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showcase/demo: Tailwind v4 upgrade test setup #4983
Draft
fpbrault
wants to merge
3
commits into
building-on-windows
Choose a base branch
from
demo/tailwind-v4-testing
base: building-on-windows
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+850
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
|
5e2c892
to
212bdc1
Compare
212bdc1
to
9dc9a7d
Compare
9dc9a7d
to
63d894d
Compare
63d894d
to
1a1b8dc
Compare
1a1b8dc
to
d5aa2a3
Compare
3f9dce2
to
763ad8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a header for the atomic examples that can be used on both this branch(with Tailwind v4 and the master branch (with Tailwind v3).
This header does a couple things:
Some changes are known/expected:
Gradient on horizontal facets in the v4 branch. This gradient was actually missing before due to a bug


Added margin under product title on mobile. A bug was preventing this margin from being applied previously.


Long product descriptions not cut off anymore in mobile width. This was a bug too!
Color of line under tabs can be changed with
--atomic-neutral
.