chore(atomic): replace lit-html with lit #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprudhomme
requested review from
olamothe,
fpbrault,
y-lakhdar and
fbeaudoincoveo
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
alexprudhomme
force-pushed
the
KIT-3977
branch
from
207e41a to
b775721
Compare
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
dmgauthier
approved these changes
Feb 19, 2025
y-lakhdar
approved these changes
Feb 19, 2025
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
pushed a commit
that referenced
this pull request
Feb 19, 2025
https://coveord.atlassian.net/browse/KIT-3977 Since `lit-html` was in devDependencies (for storybook initially) and since it serves the same purpose as `lit/html.js`, the IDE would suggest imports from `lit-html` in `src/` files which would have caused problems when npm users would install Atomic. This PR removes every mention of lit-html and replaces it with lit/html. This PR also addresses another refactor I came across with a file in `src/components/common/types.ts` that was exporting random interfaces from headless search. I removed that file and adjusted the imports across the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3977
Since
lit-htmlwas in devDependencies (for storybook initially) and since it serves the same purpose aslit/html.js, the IDE would suggest imports fromlit-htmlinsrc/files which would have caused problems when npm users would install Atomic. This PR removes every mention of lit-html and replaces it with lit/html.This PR also addresses another refactor I came across with a file in
src/components/common/types.tsthat was exporting random interfaces from headless search. I removed that file and adjusted the imports across the repo.